thervh70 / ContextProject_RDD

1 stars 0 forks source link

135 scrollin and scrollout #161

Closed MathiasMeuleman closed 8 years ago

MathiasMeuleman commented 8 years ago

Will close #135

They see mee scrollin'

ScrollInto and ScrollOutOf elements are now package into one eventhandler. For this purpose, a general Scroll event (EventID == 300) is added. This is not logged to the database, but handling this event logs either a ScrollInto or a ScrollOutOf event to the database. A custom JQuery event scroll:finish is used to restrict the amount of times a scroll event gets handled (for performance issues).

Note: because the options are not yet working, logging of scroll events is turned off by default. You have to fix this manually in order to test

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.07%) to 93.378% when pulling 9f18f59fa460cce99b5af087eda18a07abde0e10 on 135-scrollin-and-scrollout into 2f85c5ba7651a4aa546833aec478e1b117dfe921 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 93.813% when pulling 89aa532d01aaeecb9a5eb4cb43f4876916af4771 on 135-scrollin-and-scrollout into 2f85c5ba7651a4aa546833aec478e1b117dfe921 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.624% when pulling a6fb8191fb84480952661eafee91c00436605485 on 135-scrollin-and-scrollout into 2f85c5ba7651a4aa546833aec478e1b117dfe921 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling c96903c9189c63e5b88e76053390588bdc7b3879 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling 754b5d676438d9242b408178e03eb29e54c7a52c on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling 952912e530dd00557b58f0ad6b6ea857d6c29e39 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling 6f73cc39a1cfab42d6ffec6d53c599c1647eef53 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling 6f73cc39a1cfab42d6ffec6d53c599c1647eef53 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling e639bcb6823ac78360fa06836329eee24aa897d8 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

mpsijm commented 8 years ago

Looking good for me now :) Can be merged when others agree. :)

mdingjan commented 8 years ago

I've left some comments; can you have a look at them? When you've processed them, this PR can be merged.

Thanks for adding the tests btw. :D

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.233% when pulling 45e06b848ce12a491d2e1b85acdcef5d0635657d on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.242% when pulling 56a8a1bda64f92fd43a9639276886cf01e0a89fe on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.271% when pulling d341704402bfc7c31659713db0aed4f7adef6fcb on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

Exclaminator commented 8 years ago

Nice coverage increment, LGTM

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.271% when pulling 1169789a0e7e02766c9247a06ed2b590d2942f62 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 93.271% when pulling 3907a29a5c17ddb9bd6236eab6aa44f12240d174 on 135-scrollin-and-scrollout into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

mpsijm commented 8 years ago

Okkay, looking good now :) Since we looked at it in plenary, I will merge now.