Closed MathiasMeuleman closed 8 years ago
Looking good for me now :) Can be merged when others agree. :)
I've left some comments; can you have a look at them? When you've processed them, this PR can be merged.
Thanks for adding the tests btw. :D
Nice coverage increment, LGTM
Okkay, looking good now :) Since we looked at it in plenary, I will merge now.
Will close #135
They see mee scrollin'
ScrollInto and ScrollOutOf elements are now package into one eventhandler. For this purpose, a general Scroll event (EventID == 300) is added. This is not logged to the database, but handling this event logs either a ScrollInto or a ScrollOutOf event to the database. A custom JQuery event scroll:finish is used to restrict the amount of times a scroll event gets handled (for performance issues).
Note: because the options are not yet working, logging of scroll events is turned off by default. You have to fix this manually in order to test