155 implement the mouse options of the settings page

[Exclaminator]

Will close #155. Will also close #156 because I was it was easier to fix both at the same time.

All options that we talked through during the Tuesday meeting have been implemented in the DoNotWatchOptions and options.js. See #168 for more changes to Options.ts, we made sure we (mostly) did not edit the same code.

Thanks in advance for reviewing!

[coveralls]

Coverage decreased (-0.7%) to 92.406% when pulling eb7a23b9d3778ad43836242b97c491ec44088ec5 on 155_-_Implement_the_Mouse_options_of_the_settings_page into b5226ed4160f738991810400a199b8ad7c475974 on dev.

[coveralls]

Coverage decreased (-0.6%) to 92.42% when pulling aa675653a138f05047ecf42e6165d31e70b6f601 on 155_-_Implement_the_Mouse_options_of_the_settings_page into b5226ed4160f738991810400a199b8ad7c475974 on dev.

[coveralls]

Coverage decreased (-0.4%) to 92.65% when pulling 8dc0d6591e0f654d31fac2a9d05f717d7cf4fac9 on 155_-_Implement_the_Mouse_options_of_the_settings_page into b5226ed4160f738991810400a199b8ad7c475974 on dev.

[mpsijm]

I fixed a bunch of stuffs for you. Should be ready for merge now, once others agree :)

[coveralls]

Coverage decreased (-0.6%) to 92.65% when pulling 72e0a107272ff06f98c129a9246f8d7e2ed8f8ed on 155_-_Implement_the_Mouse_options_of_the_settings_page into 848ffe2d30de22195191e1a7d064d6c1317dbf88 on dev.

[coveralls]

Coverage decreased (-0.6%) to 92.645% when pulling b4cb3450abee2f22f1075f55d22685585991a2be on 155_-_Implement_the_Mouse_options_of_the_settings_page into a2c3738c50e64feea762c2f1d656b1d373c55064 on dev.

[coveralls]

Coverage decreased (-0.4%) to 92.817% when pulling 69c2888b228e6db564916eeaf6b4ebfc6c26d14b on 155_-_Implement_the_Mouse_options_of_the_settings_page into a2c3738c50e64feea762c2f1d656b1d373c55064 on dev.

[MathiasMeuleman]

Is there a reason nothing gets logged in my console? (Except for some html and semantic event posts)

[Exclaminator]

Could you give some specifics? What options are on, what does get logged? On Jun 16, 2016 6:42 PM, "MathiasMeuleman" notifications@github.com wrote:

Is there a reason nothing gets logged in my console? (Except for some html and semantic event posts)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thervh70/ContextProject_RDD/pull/166#issuecomment-226542951, or mute the thread https://github.com/notifications/unsubscribe/AAdBI7sY4x-1dWbdJMyYbBSj37zzHXkEks5qMX0BgaJpZM4I3R74 .

[MathiasMeuleman]

At the moment, the only event (semantic and raw) that gets logged in my console are start_Watching and stop_watching (401 and 402). The others event simply don't get logged (again, in my console. I don't know if they are still logged to the database, but I suspect they aren't). Also, most of the time I get two (not one) [DEBUG] hooked to DOM messages when switching tabs in GitHub. Same goes for [DEBUG] unhooked from DOM when the extension is turned off

[MathiasMeuleman]

Did some testing, only after the option "when I use the scroll wheel" has been turned off and on again, everything works. After that, this option seems to work like a huge main switch, meaning that everything breaks when turning it off and everything is up and running after turning it on again.

[coveralls]

Coverage decreased (-0.5%) to 92.808% when pulling a680435ca25b8124bdc58e6b22267d6921465f7e on 155_-_Implement_the_Mouse_options_of_the_settings_page into a2c3738c50e64feea762c2f1d656b1d373c55064 on dev.

[coveralls]

Coverage decreased (-0.5%) to 92.808% when pulling a680435ca25b8124bdc58e6b22267d6921465f7e on 155_-_Implement_the_Mouse_options_of_the_settings_page into a2c3738c50e64feea762c2f1d656b1d373c55064 on dev.

[coveralls]

Coverage decreased (-0.5%) to 92.808% when pulling a680435ca25b8124bdc58e6b22267d6921465f7e on 155_-_Implement_the_Mouse_options_of_the_settings_page into a2c3738c50e64feea762c2f1d656b1d373c55064 on dev.

[coveralls]

Coverage decreased (-0.7%) to 92.552% when pulling 5106078d3f09b4558f2e87f56bc616184f2452cb on 155_-_Implement_the_Mouse_options_of_the_settings_page into a2c3738c50e64feea762c2f1d656b1d373c55064 on dev.

[coveralls]

Coverage decreased (-0.8%) to 92.457% when pulling 14a752dabddf7939d7e7f2bb04c6604dc0e622cb on 155_-_Implement_the_Mouse_options_of_the_settings_page into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

[coveralls]

Coverage decreased (-0.8%) to 92.414% when pulling 7999831b827aadb203f757a07491d8153939c8e5 on 155_-_Implement_the_Mouse_options_of_the_settings_page into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

[coveralls]

Coverage decreased (-0.8%) to 92.414% when pulling 824a2d4e287a40dedfc5eafd288d880743c0c9a4 on 155_-_Implement_the_Mouse_options_of_the_settings_page into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

[coveralls]

Coverage decreased (-0.8%) to 92.414% when pulling 54449c880c7701cd12d0cee13cf6a08b7f56718b on 155_-_Implement_the_Mouse_options_of_the_settings_page into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

[coveralls]

Coverage decreased (-0.6%) to 91.343% when pulling 93bd4637b01d1bb4489cfd949925ce0c87259740 on 155_-_Implement_the_Mouse_options_of_the_settings_page into 83d85b5222b74df2456294db8d5f720a9e448bdd on dev.

[mdingjan]

TabChangeEvents seem to be logged when the option is turned off?

[coveralls]

Coverage decreased (-0.7%) to 91.218% when pulling fe1b7c2de22ce55a668bf35d79fb8c1afecdcb62 on 155_-_Implement_the_Mouse_options_of_the_settings_page into 83d85b5222b74df2456294db8d5f720a9e448bdd on dev.

[coveralls]

Coverage decreased (-0.7%) to 91.218% when pulling 515e89a3cc65fe794e69753e7beb037bed796b1c on 155_-_Implement_the_Mouse_options_of_the_settings_page into 83d85b5222b74df2456294db8d5f720a9e448bdd on dev.

[coveralls]

Coverage decreased (-0.6%) to 91.343% when pulling c21e00dc6bab3b24df6d82e0b7a9658281342dae on 155_-_Implement_the_Mouse_options_of_the_settings_page into 83d85b5222b74df2456294db8d5f720a9e448bdd on dev.

[MathiasMeuleman]

Yes I have tested this, it works fine now! Will merge