Xx bug decimals in database

MathiasMeuleman commented 8 years ago

Will close nothing really.

Bugfix to round floating-points to integers before logging to the database. Floating-points might occur when zooming in chrome.

coveralls commented 8 years ago

Coverage increased (+0.04%) to 93.309% when pulling 18abc07b6d9b3c5208d5491b942589eb5da5fe2a on xx-bug-decimals-in-database into 7337b52cfd4440e80c49b23800ff8b2d476034f0 on dev.

thervh70 commented 8 years ago

Hard to read method (processRounding), however this seems to work. Good job!

coveralls commented 8 years ago

Coverage increased (+0.03%) to 93.304% when pulling d8ece639d480e0f34ead1885960a4274e1e7ede6 on xx-bug-decimals-in-database into 7337b52cfd4440e80c49b23800ff8b2d476034f0 on dev.

MathiasMeuleman commented 8 years ago

I have fixed all feedback, also added additional explanatory TSDoc to the processRounding function

coveralls commented 8 years ago

Coverage increased (+0.03%) to 93.304% when pulling bb5f7cdf0eb4c6fbbb18f048824c8a589204dac9 on xx-bug-decimals-in-database into 7337b52cfd4440e80c49b23800ff8b2d476034f0 on dev.

coveralls commented 8 years ago

Coverage increased (+0.03%) to 93.304% when pulling bb5f7cdf0eb4c6fbbb18f048824c8a589204dac9 on xx-bug-decimals-in-database into 7337b52cfd4440e80c49b23800ff8b2d476034f0 on dev.

mpsijm commented 8 years ago

Looks good, at the moment I don't have time to try out the functionality, but if others confirm that it works, this can be merged. :)

mdingjan commented 8 years ago

When zoomed in, I still get 400s on mouse-position-events and mouse-scroll-events. Can you have one more look at this and try to reproduce it?

mdingjan commented 8 years ago

So I tried to reproduce the 400s again, rebuilding & deleting the old build from both the browser and the directory, but didn't succeed. The implementation does work as it is supposed to.

Maybe one more person can build the extension on this PR and check it, just to be sure?

coveralls commented 8 years ago

Coverage increased (+0.01%) to 93.284% when pulling 88111e863eabedbb44bfee241c7794d30c5a76cf on xx-bug-decimals-in-database into 7337b52cfd4440e80c49b23800ff8b2d476034f0 on dev.

mpsijm commented 8 years ago

@mdingjan I don't see any troubles, but like you said to us in the chat you don't see any problems anymore either. :) @MathiasMeuleman I like the new test, thanks a lot :) Also thanks for quickly resolving my feedback, can now be merged if others agree :)

coveralls commented 8 years ago

Coverage increased (+0.009%) to 93.28% when pulling 066a74c8e56376694ffd6364f6f6f1a25a69ce39 on xx-bug-decimals-in-database into 7337b52cfd4440e80c49b23800ff8b2d476034f0 on dev.

mdingjan commented 8 years ago

I agree, thanks for processing the feedback. :)

Exclaminator commented 8 years ago

LGTM, merging.

thervh70 / ContextProject_RDD

Xx bug decimals in database #167