thervh70 / ContextProject_RDD

1 stars 0 forks source link

Move Default Options To Backend #168

Closed mdingjan closed 8 years ago

mdingjan commented 8 years ago

Extra issue.

Main change: defaults have been removed from the frontend html pages to the options.ts backend. Also the implementation of the functionality of the 'Restore Options' button has therefore been changed.

Please review this PR by building the extension, trying to find any bugs in the frontend and of course reviewing the code. ;)

Quack!

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.998% when pulling e8359061ae735fae21e6f57371a2534e3b158e29 on xx-move-default-options-to-backend into 848ffe2d30de22195191e1a7d064d6c1317dbf88 on dev.

thervh70 commented 8 years ago

Looks good to me. This is ready to be merged.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.958% when pulling 0932f87ef1d0d5122c936f4858f0cc1a25456210 on xx-move-default-options-to-backend into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.958% when pulling a4cac5b48213294b6e35eba2f764f6404c495350 on xx-move-default-options-to-backend into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.958% when pulling 12d330bec1346d6fbbc6dd8fae6f85c0552938b8 on xx-move-default-options-to-backend into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.958% when pulling 5cdbbd8be1ab94fb01d60098e6ee928e7cb00648 on xx-move-default-options-to-backend into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.4%) to 91.843% when pulling 0038cb40d88129d6f9e2cbe3adf018e926af6bb0 on xx-move-default-options-to-backend into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

mpsijm commented 8 years ago

It's all looking so fancy now :D Can be merged! :)

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.3%) to 91.906% when pulling 5f3a35dc2f4e9d021cfffdef9af60370c0f5afe1 on xx-move-default-options-to-backend into 998d5d03c65f47632610c8ef878cc8c577dd730a on dev.

Exclaminator commented 8 years ago

I fixed some styling issues, PR looks good, going to merge now.