181 status running on reload

thervh70 / ContextProject_RDD

1 stars 0 forks source link

181 status running on reload #185

Closed mpsijm closed 8 years ago

mpsijm commented 8 years ago

Will close #181

The status was set wrongly because isActiveTab was manually decided in all Chrome API callbacks. I've added MainController.getCurrentTab((Tab) => void) to make sure it can be tested whether any tab that gets updated is the current tab.

Please confirm that the bug is gone by clicking everything :) Have fun reviewing! :D

coveralls commented 8 years ago

Coverage increased (+0.009%) to 91.724% when pulling 099018114dbdadd140351052ba386bafcd7cf1bc on 181-status-running-on-reload into 89756124c2a92a9eaf9801d8922db3d33700f3d7 on master.

mpsijm commented 8 years ago

Closed because should be merged into dev.