search

thervh70 / ContextProject_RDD

1 stars 0 forks source link

181 status running on reload #188

Closed mpsijm closed 8 years ago

mpsijm commented 8 years ago

Will close #181

The status was set wrongly because isActiveTab was manually decided in all Chrome API callbacks. I've added MainController.getCurrentTab((Tab) => void) to make sure it can be tested whether any tab that gets updated is the current tab.

Please confirm that the bug is gone by clicking everything :) Have fun reviewing! :D

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.009%) to 91.724% when pulling 099018114dbdadd140351052ba386bafcd7cf1bc on 181-status-running-on-reload into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.009%) to 91.724% when pulling fa8dbe3a1a5c75ec615540d5a0aca130f393210f on 181-status-running-on-reload into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

mdingjan commented 8 years ago

Everything works, I couldn't break it by retrieving a different icon than I expected. (And thanks for resolving my feedback. ^^ ) Nice, ready for merging!

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.009%) to 91.724% when pulling cbe017eb742bdb16556511be4bc326bfb600a4c8 on 181-status-running-on-reload into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

thervh70 commented 8 years ago

Bug is gone! PR will be merged!