search

thervh70 / ContextProject_RDD

1 stars 0 forks source link

Made sure empty cells don't get logged therefore preventing 400 error's #190

Closed Exclaminator closed 8 years ago

Exclaminator commented 8 years ago

Will close #180.

Made sure empty cells don't get logged therefore preventing 400 error's

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 91.714% when pulling 59250058aed8c2a6a02b905189d94048829bbc14 on 180_-_400_status_code_when_hovering_over_empty_line_number into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

mpsijm commented 8 years ago

I am now getting 400 errors when hovering over lines of code?

Exclaminator commented 8 years ago

@mpsijm and me tried replicating his error on my machine, seems to be working properly here.

Exclaminator commented 8 years ago

@aaronang will change this in the database.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.619% when pulling e72cbdaa2ba770a857106f9982e610ae468d9e8d on 180_-_400_status_code_when_hovering_over_empty_line_number into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

mdingjan commented 8 years ago

I couldn't break it; I like it. :) Add some more tests and I'ma happy duck. :) After that, ready for merging.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.08%) to 91.789% when pulling 3f09e3d8d5f2d87aca40f7d5a8d94fb103419841 on 180_-_400_status_code_when_hovering_over_empty_line_number into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.07%) to 91.789% when pulling c671f5354ce619a944688519a276c618b99a7243 on 180_-_400_status_code_when_hovering_over_empty_line_number into e9e8326e9e480bd7119b2c4ae25b08aa35cae969 on dev.

mpsijm commented 8 years ago

Okay, I've added some more tests and it all works now. A few more reviews and this can be merged :)

mdingjan commented 8 years ago

Thanks for adding the extra tests! Ready for merge :)

thervh70 commented 8 years ago

+0.07 i like this :p

Looking good and unbreakable, will merge!