102 set error status - Githubissues

thervh70 / ContextProject_RDD

1 stars 0 forks source link

102 set error status #191

Closed mpsijm closed 8 years ago

mpsijm commented 8 years ago

Will close #102 ~~Please merge #188 and #189 first, as this PR depends on those PRs.~~

I made sure the ERROR status is set on two occasions:

The DatabaseAdapter calls the failure callback
The ContentController errors while hooking to DOM

If there are other occasions that should have an ERROR status, please tell me :)

Have fun breaking our extension :D

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 91.567% when pulling 3a1a31e209eeb2dd118247ecc731ba23ce600e28 on 102-set-error-status into 276a96fcc908c899337911374780ec6fcc7c3908 on dev.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.567% when pulling aaa56e6b811afac197bf0df1d5c7ed13d8154e97 on 102-set-error-status into e9e8326e9e480bd7119b2c4ae25b08aa35cae969 on dev.

mdingjan commented 8 years ago

Running on reload bug popped up again.. :o

mpsijm commented 8 years ago

I have confirmed and identified the bug indeed :open_mouth: Will fix now :)

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.515% when pulling 8b88326bdd43ff3258b6d6d111e3c214bc7adf4b on 102-set-error-status into e9e8326e9e480bd7119b2c4ae25b08aa35cae969 on dev.

mpsijm commented 8 years ago

I fixed it :) A fun way to test the entire PR btw is to throw "duck"; on line 88 of the ContentController (inside the try block) :smile:

mdingjan commented 8 years ago

The bug has indeed been fixed. Thanks! :)

thervh70 commented 8 years ago

Looks good. The error status pops up nicely.

Will merge!