search

thervh70 / ContextProject_RDD

1 stars 0 forks source link

Format space keystroke #192

Closed mpsijm closed 8 years ago

mpsijm commented 8 years ago

In the RestAPIDatabaseAdapter, " " is now rewritten to "Space" to avoid 400 errors. I asked @aaronang about this and he approves this change.

Have fun reviewing, it's not much :)

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.04%) to 91.686% when pulling 6be203f9bcd2f1d1d042aa7cb70c9397b0e437a7 on _-format-space-keystroke into e9e8326e9e480bd7119b2c4ae25b08aa35cae969 on dev.

Exclaminator commented 8 years ago

Please add a test for this.

Met vriendelijke groet, Youri Arkesteijn

On Thu, Jun 23, 2016 at 4:56 PM, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/6724295

Coverage decreased (-0.04%) to 91.686% when pulling _6be203f https://github.com/thervh70/ContextProject_RDD/commit/6be203f9bcd2f1d1d042aa7cb70c9397b0e437a7 on -format-space-keystroke into _e9e8326 https://github.com/thervh70/ContextProject_RDD/commit/e9e8326e9e480bd7119b2c4ae25b08aa35cae969 on dev_.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thervh70/ContextProject_RDD/pull/192#issuecomment-228076681, or mute the thread https://github.com/notifications/unsubscribe/AAdBI7Tbqbp4QVEDpkjtl2r4gQatwWgQks5qOp6cgaJpZM4I85V- .

mpsijm commented 8 years ago

@Exclaminator I wrote a test, thanks for noticing :)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 91.761% when pulling 928b973b8ef51d40dd3c9894e4be268c74efc618 on _-format-space-keystroke into e9e8326e9e480bd7119b2c4ae25b08aa35cae969 on dev.

mdingjan commented 8 years ago

Logging a space works nicely. :) Thanks for adding the extra test.

Ready for merging!

thervh70 commented 8 years ago

Looking very good. No more debugging errors! Will merge.