Added a license. - Githubissues

thervh70 / ContextProject_RDD

1 stars 0 forks source link

Added a license. #196

Closed Exclaminator closed 8 years ago

Exclaminator commented 8 years ago

Please review this carefully.

coveralls commented 8 years ago

Changes Unknown when pulling ab788a343ec04a1fa7c2646275fe8be5d96b51e3 on XX-Add_a_licence into \ on dev**.

mpsijm commented 8 years ago

Shouldn't we note the licence type?

mpsijm commented 8 years ago

Also, don't forget to add the license type to package.json and manifest.json :)

mdingjan commented 8 years ago

All of the above and then ready for merging. ;)

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.62% when pulling f0483eabae6020bb7d2dff6e9cd79e9d62e0f0dc on XX-Add_a_licence into 1e5979e20ca3ff4df66367b5cd0bb3be34794d50 on dev.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.62% when pulling 620d0c643f2747aa6a0ac78be2f18105087107dc on XX-Add_a_licence into 1e5979e20ca3ff4df66367b5cd0bb3be34794d50 on dev.

mdingjan commented 8 years ago

As Youri didn't have time for finishing the feedback on this PR, I resolved it. Please give this a final review and notify me if something still has to be changed. Else, please merge this PR.

mpsijm commented 8 years ago

Can the license file be renamed to LICENSE.md? This is more conventional. :)

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.62% when pulling bcd631ae0546ccb9746fd8c75b55b98f6c916917 on XX-Add_a_licence into 1e5979e20ca3ff4df66367b5cd0bb3be34794d50 on dev.

Exclaminator commented 8 years ago

LGTM

mpsijm commented 8 years ago

This has been open long enough, will merge now :) (First ever merge from France! yay! :D )