search

therynamo / color-links

🔗 Help Individuals With Color Blindness See Visited Links
https://chrome.google.com/webstore/detail/color-links/hiponeioelghhaljfflaaflpccedbdem
16 stars 7 forks source link

custom input component first draft #14

Closed Kageetai closed 6 years ago

Kageetai commented 6 years ago

This small component just shows a standard input field where the user can choose and custom color and then press save to use it as the color for the visited links.

therynamo commented 6 years ago

Hey @Kageetai, thank you for taking time to contribute to color-links! It is great to see you've tackled a help wanted feature.

I wanted drop in and let you know I'm going to review this within the next few days. I have a few suggestions, but overall, it looks fantastic.

Thanks again for your time, contributions, and making color-links better!

Kageetai commented 6 years ago

Sure, I mostly did it for myself because I wanted that feature myself ;) Wasn't sure about any additional design for the input, but thought a first version is a good start.

therynamo commented 6 years ago

@Kageetai, this was definitely a great start. This has been on the help wanted list for some time: see #6.

Again, I want to thank you for your contributions. I think this will be a nice addition, and we can use a lot of what you have here with a few improvements.

Here is an Invision link for a 'nice to have' flow with a custom input and styles. https://invis.io/4YF7Z2WQU. The 'color' changing of the input border on hex input isn't necessary in terms of this PR. If you're feeling ambitious though, that'd be awesome.

Before doing a general release of this feature, here is a list of some things I noticed about the UX:

Let me know what you think of the proposed changes above. I'd be happy to make a PR into your PR here if you wanted help with any of these things. Just let me know and I can get to work.

Kageetai commented 6 years ago

Thanks. Nice to hear that it's on the right track. Of course it was just meant as a first draft and I was expecting suggestions for design and other changes. So of course I will tackle those probably on the weekend here.

therynamo commented 6 years ago

Awesome, that is great news! I look forward to seeing your updates @Kageetai 👍 🎉

Kageetai commented 6 years ago

@therynamo as you can I see I added some more changes and if I didn't overlook anything all your requested changes should be implemented now. Maybe you can take another look :)

therynamo commented 6 years ago

@Kageetai , I'm terribly sorry it took so long to get back to you. Since this is my "free time" project, I haven't had a great deal of time to review your new updates. The good news is, I have now!

I love what you've done here, really simple, really effective. I'm going to go ahead and merge this in now. I am going to remove the activeColor wiping in showCustomInput() so we maintain that color. After doing that I'll go ahead and release this out to the public.

I really appreciate your work on this @Kageetai. It has been a pleasure, and as always, feel free to continue contributing to anything you feel may make users lives better!

therynamo commented 6 years ago

These changes have been published on the chrome store. You should see the changes reflect within 60 minutes. Great work @Kageetai!

Kageetai commented 6 years ago

Hey, I nearly forgot about this PR myself ;) But glad it worked out and you could even fix this little bug this easily. Not sure how I overlooked that. Happy to contribute :)