search

therynamo / color-links

🔗 Help Individuals With Color Blindness See Visited Links
https://chrome.google.com/webstore/detail/color-links/hiponeioelghhaljfflaaflpccedbdem
16 stars 7 forks source link

Only URLs are being color-converted #16

Closed rEnr3n closed 4 years ago

rEnr3n commented 6 years ago

screenshot_2018-03-17_11-04-57

I set my color to red. I clicked the wikipedia page in the screenshot. The title doesn't change to my set color. Only the URL at the bottom does even though both of them are poined at the same link.

I tried it on youtube and since there are no URLs present on the page, there are no color changes. Some links on youtube change color but some don't.

Can you make an option so that all other elements (including images) get converted to the set color?

therynamo commented 4 years ago

Hey @rEnr3n, sorry it took so long to look into this issue. I think this can be broken out into two different issues.

I set my color to red. I clicked the wikipedia page in the screenshot. The title doesn't change to my set color. Only the URL at the bottom does even though both of them are poined at the same link.

I'll mark this as a bug.

Can you make an option so that all other elements (including images) get converted to the set color?

This would be more of a feature, and we could discuss what that might look like. Perhaps a good opportunity for a PR that demonstrates what you're looking for.

therynamo commented 4 years ago

Fixed!

image

Once #29 is merged and published to the chrome store, you'll see the changes reflected. Thanks for the bug report!