thesabbir / simple-line-icons

Simple and Minimal Line Icons
https://thesabbir.github.io/simple-line-icons
MIT License
1.86k stars 845 forks source link

Syntax error in simple-line-icons/scss/simple-line-icons.scss #11

Closed mvastola closed 9 years ago

mvastola commented 9 years ago

Hi, The Sass gem in Ruby doesn't seem to like the syntax of simple-line-icons/scss/simple-line-icons.scss.

I'm getting the following error on Rails: action_controller_exception_caught_-_2015-02-14_09 53 12

The suspect code seems to be:

.#{$simple-line-icon-prefix} {
  &user-female, &user-male {
    /* CSS rules go here */
  }
}

By my reading, sass seems to not like the &user-female syntax.

Thanks for your help.

thesabbir commented 9 years ago

@mvastola I am not familiar with scss. @zeshanshani added scss support & I hope he can help.

zeshanshani commented 9 years ago

Hi @mvastola,

This should work in Sass 3.3.0 version (Sass Changelong):

The parent selector, &, can be used with an identifier suffix. For example, &-suffix and &_suffix are now legal. The suffix will be added to the end of the parent selector, and will throw an error if this isn’t possible. & must still appear at the beginning of a compound selector – that is, .foo-& is still illegal.

Thanks!

mvastola commented 9 years ago

Oh. Oops. I had my sass-rails gem locked at too low a version, I guess. Fixed! Thanks.

zeshanshani commented 9 years ago

Cool.