search

thesabbir / simple-line-icons

Simple and Minimal Line Icons
https://thesabbir.github.io/simple-line-icons
MIT License
1.86k stars 845 forks source link

Add !default on SCSS variables #116

Closed garbinmarcelo closed 4 years ago

garbinmarcelo commented 4 years ago

Add !default to SCSS variables so they can be subscribed to.

jrubins commented 4 years ago

It seems like @garbinmarcelo and I were both experiencing the same problem and both opened pull requests at the same time. Just wanted to link my PR to this issue as well so we can make sure to deal with both of them! #117

thesabbir commented 4 years ago

Resolved by #117

Thanks to @jrubins

jrubins commented 4 years ago

@thesabbir I see that there was a new release (v2.5.4) but it looks like it was for githash ccba29d, which doesn't include the changes from my merged PR. Do you mind crafting another release so we can get those SASS default fixes?

thesabbir commented 4 years ago

@jrubins missed that part. v2.5.5 is available now