Retire the need for cached genshin character names - Githubissues

thesadru / genshin.py

API wrapper for HoYoLAB/Miyoushe API built on asyncio and pydantic.

https://thesadru.github.io/genshin.py

MIT License

395 stars 72 forks source link

Retire the need for cached genshin character names #61

Closed thesadru closed 1 year ago

thesadru commented 2 years ago

By fetching data dynamically from (for example) enka's database or ambr.top we could eliminate the need to have a pr every single genshin update.

Why not just use purely the API

character names are not provided for many endpoints
no endpoint provides all names, icons, and ids
- wiki uses custom ids and icons
- calculator does not have consistent icons

Requirements

[x] pass the language to every model (scope fuckery or major rewrite)
[x] Fix whatever the hell this error is
[x] find a way to cache things effectively in-between runs
[x] update the documentation
[ ] hope to god the enka repo or ambr can never get shut down

thesadru commented 1 year ago

Welp tests are passing, might as well just consider this done.