search

thesadru / genshinstats

PLEASE USE GENSHIN.PY A python library that can get the stats of Genshin Impact players using Mihoyo's API. PLEASE USE GENSHIN.PY
https://thesadru.github.io/pdoc/genshinstats/
MIT License
268 stars 38 forks source link

Update to 1.4 #10

Closed thesadru closed 3 years ago

thesadru commented 3 years ago

This update will probably break every project using it, so I'd like to take it slowly and make sure this can be the final version excluding bugfixes and minor updates.

whyhellothere commented 3 years ago

Did you remove the get_active_players() function? If so, why?

thesadru commented 3 years ago

I had issues with pagination because mihoyo eventually started to ratelimit me when I tried to go over 200 players. Since it didn't really fit this project in the first place I just removed it.

If you feel like I should add it back I can however it will still be limited to around 200 players.