search

thesadru / genshinstats

PLEASE USE GENSHIN.PY A python library that can get the stats of Genshin Impact players using Mihoyo's API. PLEASE USE GENSHIN.PY
https://thesadru.github.io/pdoc/genshinstats/
MIT License
265 stars 38 forks source link

[Question] Why asyncify was removed? #24

Closed alsoGAMER closed 3 years ago

alsoGAMER commented 3 years ago

I used it everywhere in my project to ensure that the queries to the mihoyo apis weren't blocking my async stuff, what i can do about it now?

thesadru commented 3 years ago

I removed it in favor of asyncio.to_thread(), I didn't know about it before so I tried to implement my own but when I found out about a function that does the exact same thing and is builtin I didn't see a reason for my own to even be a thing.