genshinstats.get_spiral_abyss() method returns Yanfei character name as 'Feiyan'

thesadru / genshinstats

PLEASE USE GENSHIN.PY A python library that can get the stats of Genshin Impact players using Mihoyo's API. PLEASE USE GENSHIN.PY

https://thesadru.github.io/pdoc/genshinstats/

MIT License

268 stars 38 forks source link

genshinstats.get_spiral_abyss() method returns Yanfei character name as 'Feiyan' #26

Closed CustomIcon closed 3 years ago

CustomIcon commented 3 years ago

i assume this is how they do in chinese, but here is my output:

also charcter icon too haha: https://upload-os-bbs.mihoyo.com/game_record/genshin/character_icon/UI_AvatarIcon_Feiyan.png

thesadru commented 3 years ago

Yup, that's a problem with how Mihoyo handles the endpoint. Normally you only get returned the character's id, rarity, and icon, I have to get the name by pulling it out of the icon. Multiple other characters already have this issue so I can just add it for Yanfei no problem. Thanks for informing me.