search

thesadru / genshinstats

PLEASE USE GENSHIN.PY A python library that can get the stats of Genshin Impact players using Mihoyo's API. PLEASE USE GENSHIN.PY
https://thesadru.github.io/pdoc/genshinstats/
MIT License
265 stars 38 forks source link

Respons said "Users data not public" but actualy it is public #44

Closed ahmadkeren closed 2 years ago

ahmadkeren commented 2 years ago

Excuse me... I check UID: 803049088, and the server said "User's data is not public". But i already publish my battle cronicle (https://webstatic-sea.mihoyo.com/app/community-game-records-sea/index.html?bbs_presentation_style=fullscreen&bbs_auth_required=true&v=101&gid=2&user_id=19423466&lang=id-id#/ys)

ahmadkeren commented 2 years ago

Hoyolab account for that user: https://www.hoyolab.com/accountCenter/postList?id=19423466

ahmadkeren commented 2 years ago

image

thesadru commented 2 years ago

Doesn't look public to me image

testalis commented 2 years ago

I've noticed this as well. I think it might have to do with the recent hoyolab update or maintenance (?). The old "public" button in the profile page is no longer there. I enable "Show my Battle ... profile" but it somehow gets disabled automatically later. Even when it's enabled, I still cannot access the information through this API. By the time I'm writing this, it's still enabled in the hoyolab page and hopefully you could check. uid: 623198312 hoyolab id page: https://www.hoyolab.com/accountCenter/postList?id=124620422

thesadru commented 2 years ago

Interesting. genshinstats seems to be able to access the data but genshin.py isn't. Seems super random.

testalis commented 2 years ago

thanks for the response. yeah I noticed it because I couldn't submit battle record to the spiralabyss.org website but they don't respond in github issues XD

thesadru commented 2 years ago

I am guessing this must be based on something super weird like some random header. I'll try to look into it but I'm completely lost as to what this could be caused by.

testalis commented 2 years ago

i see, thx! so will this command "spiral_abyss = gs.get_spiral_abyss(uid, previous=True)" still work again? you mentioned genshinstats can still access the data but isn't this command based on genshinstats?

thesadru commented 2 years ago

It works for me

testalis commented 2 years ago

even for my uid? data = gs.get_user_stats(623198312) this line returns DataNotPublic: User's data is not public

thesadru commented 2 years ago

Oh, that's weird. I don't seem to be getting an error at all.

thesadru commented 2 years ago

This issue should now be resolved after the hoyolab server migration. Try updating genshinstats to 1.4.11.1.