search

thesadru / genshinstats

PLEASE USE GENSHIN.PY A python library that can get the stats of Genshin Impact players using Mihoyo's API. PLEASE USE GENSHIN.PY
https://thesadru.github.io/pdoc/genshinstats/
MIT License
265 stars 38 forks source link

Make the warnings in the README a bit more lenient. #61

Closed fdeblic closed 1 year ago

fdeblic commented 2 years ago

Rewrite the documentation to point out specific dangers of sharing your cookies and inform users which ones are safe to share in what circumstances. This is to make the act of giving your cookies away a bit less scary and enable various tools like spiralstats to collect data easier.

thesadru commented 2 years ago

Alright I know I have said that giving away your cookies may not be that detrimental but at the same time, you're making it seem way too safe. While it seems that your account may not be stolen you can absolutely get for example impersonated in the forums. Rather than ltoken being "quite safe" it's closer to it being detrimental in the wrong hands.

Awareness is key. It's better to inform users what the implications of giving away your cookies are rather than broadly claim that it's not a big deal.