search

thesadru / genshinstats

PLEASE USE GENSHIN.PY A python library that can get the stats of Genshin Impact players using Mihoyo's API. PLEASE USE GENSHIN.PY
https://thesadru.github.io/pdoc/genshinstats/
MIT License
268 stars 38 forks source link

check_in() problem #7

Closed rushkii closed 3 years ago

rushkii commented 3 years ago

Hello authors, I've an issue about the check_in() function, when I call this function it is success without error raised, but when I check on Hoyolab web and I refresh the page it is not really checked-in. How to solve this?

This is the page I'm talking about, right? https://webstatic-sea.mihoyo.com/ys/event/signin-sea/index.html?act_id=e202102251931481&lang=en-us

opabravo commented 3 years ago

check_in() function doesn't claim daily rewards, it gives you points on hoyolab's site sign_in() is the one you are looking for You should go read the doc

opabravo commented 3 years ago

@thesadru I find out the function name check_in() is a bit misleading Because "Check in" is the title of the daily rewards page https://webstatic-sea.mihoyo.com/ys/event/signin-sea/index.html?act_id=e202102251931481&lang=en-us How do you think if it switch names with sign_in()?

thesadru commented 3 years ago

At that point, we should just completely rename the functions. I propose hoyolab_check_in and claim_daily_rewards, but I welcome any suggestions.

While we're at that it would be a good idea to rename a lot of functions, like get_all_characters, get_gacha_log, get_entire_gacha_log, get_all_gacha_ids and get_uid_from_community. If this is something you would consider important I could just open a new issue for it. In my opinion, we should change them while the project is still small.

thesadru commented 3 years ago

Created a new dev branch. I'll take any further suggestions.