search

thesamet / rpcz

RPC implementation for Protocol Buffers over ZeroMQ
http://code.google.com/p/rpcz/
Apache License 2.0
111 stars 42 forks source link

Windows and zmq 3.x support #1

Closed jcooper-korg closed 9 years ago

jcooper-korg commented 9 years ago

Hi Nadav,

I added some comments to the commits, explaining the changes.

Our CMake infrastructure is part of a larger system using our own builds of protobuf, boost, zeromq, etc. So I didn't include our changes to the CMakeList.txt files...

Let me know if you have any questions! John

mhaberler commented 9 years ago

Hi @jcooper-korg - curious, what is the status of this Windows support PR?

jcooper-korg commented 9 years ago

Nadav never responded to my pull request.

thesamet commented 9 years ago

Hey, sorry I was hoping (for a few months) to find the time to try this out on a Windows machine. I don't see this is happening in the near future, but your change seems reasonable so I would be happy to merge it in and we can work from there if there are any issues. Will you be able to rebase the change and I'll merge it in as soon as that happens?

jcooper-korg commented 9 years ago

Hi Nadav, I just merged upstream. There was one merge conflict in reactor.cc. My previous change had already implemented zmq 3.x compatibility, so I kept my changes instead of these: https://github.com/thesamet/rpcz/commit/5777ac390b18505ba302718a05ba815ff4664bc1#diff-c9b3be8f0aa541adc78269d7820391aa -John

jcooper-korg commented 9 years ago

I added a couple more commits, tidying. The Travis Cl build is failing due to a CMake configuration issue (boost_system package not found), but I didn't commit any changes to the CMakeLists.txt so I don't think it's related to my work.

thesamet commented 9 years ago

Thanks for working on this!