search

thesamim / TickTickSync

GNU General Public License v3.0
99 stars 2 forks source link

Done dates are not being inserted #64

Closed Suyashtnt closed 3 months ago

Suyashtnt commented 4 months ago

When marking a task as done in ticktick, the task's done date is not inserted into obsidian. This makes the todo plugin and it's API think that the task was not completed yet, leading to issues with other plugins and ```task block

image While this is done, it shows up as not being done as it doesn't have a done date attached. image

thesamim commented 4 months ago

@Suyashtnt : are you using the Tasks plugin?

If you are: done dates are inserted by Tasks and not touched by TickTickSync. If you are seeing different behavior, please let me know.

If you are not: I strongly recommend using the Tasks plugin because all the date logic, query logic etc is supported by the Tasks plugin....

Also: that plugin should be determining done status based on the task checkbox status. Could you please give me a link to that plugin so I can test on my side?

Suyashtnt commented 4 months ago

@Suyashtnt : are you using the Tasks plugin?

If you are: done dates are inserted by Tasks and not touched by TickTickSync. If you are seeing different behavior, please let me know.

If you are not: I strongly recommend using the Tasks plugin because all the date logic, query logic etc is supported by the Tasks plugin....

Also: that plugin should be determining done status based on the task checkbox status. Could you please give me a link to that plugin so I can test on my side?

I am using the tasks plugin. The menu I showed is the tasks plugin ```tasks block. The tasks plugin itself doesn't determine if something is done based on if its checked or not, but rather based on the presence of the done field

thesamim commented 4 months ago

Thanks for pointing out the issue. Should be fixed now.

Suyashtnt commented 4 months ago

new issue: the plugin moves it into a place where the task plugin no longer takes is into consideration. It should be moved to the end of the line rather than before link

- [X] English comprehension          ✅ 2024-03-07  [link](https://ticktick.com/webapp/#p/inbox123040542/tasks/65e70b795b708c8a7308b71c) #ticktick %%[ticktick_id:: 65e70b795b708c8a7308b71c]%% 📅 2024-03-07

image (the tasks plugin ```task block is showing that I have not completed it yet)

thesamim commented 4 months ago

Please update to 1.0.18. Please let me know results.

Suyashtnt commented 3 months ago

It seemingly removed the done tag rather than move it. image

- [X] Business cycle test #business [link](https://ticktick.com/webapp/#p/inbox123040542/tasks/65ba9f155f2e6656d28f8b8a) #ticktick %%[ticktick_id:: 65ba9f155f2e6656d28f8b8a]%% 📅 2024-02-29
thesamim commented 3 months ago

Could you please give me reproduction steps?

Specifically:

  1. Where did you mark the task as closed from?
  2. Did you wait for a Sync, or force a Sync?

Also, in Tasks plugin settings do you have this turned on: image

Suyashtnt commented 3 months ago

sorry that I completely forgot about this issue. I'll test it when I have a chance.

thesamim commented 3 months ago

I did find a couple of issues that I believe I fixed. Looking forward to hearing your results.

Suyashtnt commented 3 months ago

I did find a couple of issues that I believe I fixed. Looking forward to hearing your results.

seems to be working perfectly now!

thesamim commented 3 months ago

Thanks for the update.