thesamim / TickTickSync

GNU General Public License v3.0
99 stars 2 forks source link

"Hide comments" in styles.css breaks comments in other code blocks #71

Closed LemurTech closed 4 months ago

LemurTech commented 4 months ago

The first line of css in the current version is this:

.cm-line:not(:hover):not(.cm-active) span.cm-comment { display: none; }

It has the unintended consequence of hiding comment blocks in ALL code blocks that are of the "cm-comment" class. It should probably be something like:

.cm-line:not(:hover):not(.cm-active) span.cm-comment:not(.cm-hmd-codeblock) { display: none; }

Thanks for this great plugin!

thesamim commented 4 months ago

@LemurTech : Thanks for raising this.

Will be in next release.

Q: if I'm reading this right, this only prevents the hiding of comments inside code blocks. Is that right? Is that the desired outcome?

You're welcome! Thanks for using it.

LemurTech commented 4 months ago

Q: if I'm reading this right, this only prevents the hiding of comments inside code blocks. Is that right? Is that the desired outcome?

Yes, that's the intention. It's working for me so far. All my comments in PowerShell code blocks were getting hidden except when hovered over.

thesamim commented 4 months ago

@LemurTech : thanks for the confirmation.