search

thesayyn / protoc-gen-ts

Compile protocol buffer messages to TypeScript.
MIT License
360 stars 74 forks source link

npm package needs publishing to include fix for typescript >= 5 #225

Closed wdoconnell closed 1 year ago

wdoconnell commented 1 year ago

This PR https://github.com/thesayyn/protoc-gen-ts/pull/204 (April 1 2023) fixed a check that was causing protoc-gen-ts to decline to run if the user had a typescript version above 5. The fix is in, but protoc-gen-ts and plugins that rely on it won't work until the npm package is updated.

https://www.npmjs.com/package/protoc-gen-ts (last updated Mar. 2023)

drbild commented 1 year ago

Does this peerDependency need to be updated as well?

wdoconnell commented 1 year ago

Yes, I think so

wdoconnell commented 1 year ago

Which folks have authority to handle npm publication?

thesayyn commented 1 year ago

Does this peerDependency need to be updated as well?

Can somebody send a PR for this? I'll cut a release after the fix lands.

wdoconnell commented 1 year ago

@thesayyn thanks very much - I'll push up a PR tomorrow.

wdoconnell commented 1 year ago

@thesayyn All set - added a PR for this.

wdoconnell commented 1 year ago

@thesayyn Is it possible for you to cut a new npm release now that this is merged? Thanks very much.

thesayyn commented 1 year ago

https://github.com/thesayyn/protoc-gen-ts/releases/tag/0.8.7 is up