Open thescientist13 opened 3 years ago
Double checking on this as part of #30 , and now it looks like MacOS is out of the loop now :/
https://github.com/thescientist13/gallinago/actions/runs/7317090092/job/19932295698
------------|---------|----------|---------|---------|---------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------|---------|----------|---------|---------|---------------------
All files | 91.93 | 87.5 | 100 | 91.93 |
src | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
src/lib | 91.52 | 87.09 | 100 | 91.52 |
runner.js | 91.52 | 87.09 | 100 | 91.52 | 61-63,[68](https://github.com/thescientist13/gallinago/actions/runs/7317090092/job/19932295698#step:6:69)-[72](https://github.com/thescientist13/gallinago/actions/runs/7317090092/job/19932295698#step:6:73),110-111
------------|---------|----------|---------|---------|---------------------
=============================== Coverage summary ===============================
Statements : 91.93% ( 114/124 )
Branches : 87.5% ( 28/32 )
Functions : 100% ( 5/5 )
Lines : 91.93% ( 114/124 )
================================================================================
https://github.com/thescientist13/gallinago/actions/runs/7317090092/job/19932295636
------------|---------|----------|---------|---------|---------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------|---------|----------|---------|---------|---------------------
All files | 91.93 | 87.5 | 100 | 91.93 |
src | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
src/lib | 91.52 | 87.09 | 100 | 91.52 |
runner.js | 91.52 | 87.09 | 100 | 91.52 | 61-63,[68](https://github.com/thescientist13/gallinago/actions/runs/7317090092/job/19932295636#step:6:69)-[72](https://github.com/thescientist13/gallinago/actions/runs/7317090092/job/19932295636#step:6:73),110-111
------------|---------|----------|---------|---------|---------------------
=============================== Coverage summary ===============================
Statements : 91.93% ( 114/124 )
Branches : 87.5% ( 28/32 )
Functions : 100% ( 5/5 )
Lines : 91.93% ( 114/124 )
================================================================================
------------|---------|----------|---------|---------|---------------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------|---------|----------|---------|---------|---------------------------
All files | 90.32 | 84.84 | 100 | 90.32 |
src | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
src/lib | 89.83 | 84.37 | 100 | 89.83 |
runner.js | 89.83 | 84.37 | 100 | 89.83 | 61-63,68-72,77-78,110-111
------------|---------|----------|---------|---------|---------------------------
=============================== Coverage summary ===============================
Statements : 90.32% ( 112/124 )
Branches : 84.84% ( 28/33 )
Functions : 100% ( 5/5 )
Lines : 90.32% ( 112/124 )
================================================================================
ERROR: Coverage for branches (84.84%) does not meet global threshold (85%)
Type of Change
Summary
As part of landing Windows support in #20 , it was observed that nyc generated code coverage was different in Windows (lower) vs Ubuntu (higher).
Details
10 (or more!) point different sometimes. 😳
Windows
Ubuntu