thescientist13 / git-explorer

Offline-first support for previewing and comparing branches in a local git repository.
MIT License
16 stars 5 forks source link

client side dependencies not loading when using git explorer #17

Closed thescientist13 closed 4 years ago

thescientist13 commented 4 years ago

Type of Change

Summary

As was kind of expected, running the installer shows 404s for the client side assets

client-assets-404

Details

Likely need to figure out a better way to detect a non development usage

app.use(express.static(path.join(process.cwd(), 'node_modules')));

and pick _nodemodules from the user's global _nodemodules location

thescientist13 commented 4 years ago

Some potentially useful links

thescientist13 commented 4 years ago

Phew, that did it!

Screen Shot 2019-12-02 at 8 41 11 PM

Confirmed with both npx and npm install -g