search

thesePeople / CustomRitualFramework

A mod for the game Rimworld that adds a framework for adding new custom Ideological Rituals
5 stars 1 forks source link

Event obligation triggers display two messages #5

Closed thesePeople closed 3 years ago

thesePeople commented 3 years ago

It doesn't seem to be two obligations, or at least if it is they are both clearing as expected, but a trailing message continues to display

thesePeople commented 3 years ago

So far this has only occurred for ability-linked rituals that I've seen. Regular rituals don't seem to do it.

thesePeople commented 3 years ago

Narrowed it down further - it looks like there's a phantom ritual attached to the Ideo

thesePeople commented 3 years ago

OK! I think I have a resolution, and it's actually simpler than we thought and not a base game bug.

In the PreceptDef for the ritual, make sure that allowDuplicates is false. More importantly, remove the preceptInstanceCountCurve field entirely. None of the other Role ability rituals have it, so it's not necessary to add the ritual to your list. BUT what preceptInstanceCountCurve is used for is deciding on whether to add that ritual to an Ideo (and how many). It should only be adding the one from the ability from the Role, so an extra one was being generated.

thesePeople commented 3 years ago

Pretty sure the change to the PreceptDef fixes this