search

thesecretmaster / predis-v0

Like redis, but parallel and written from scratch for fun!
GNU General Public License v3.0
1 stars 0 forks source link

Unsafe usage of the hashtable #14

Closed thesecretmaster closed 5 years ago

thesecretmaster commented 5 years ago

In https://github.com/thesecretmaster/predis/commit/95d27878f2d9ce962bae420dc81a0382ad4eff7f the command structure was rewritten to support hashtables. However, using the hashtable before the per-thread safe flag is set will cause undefined behavior, since the clean job assumes that once every thread is safe no reads/writes are occuring.

thesecretmaster commented 5 years ago

Closing since we now have included the hashtable into the base predis implementation.