search

thesecretmaster / predis-v0

Like redis, but parallel and written from scratch for fun!
GNU General Public License v3.0
1 stars 0 forks source link

Strange bugs around rval->value being uninitialized when attempting to get from a full predis instance #16

Open thesecretmaster opened 5 years ago

thesecretmaster commented 5 years ago

Pretty much the title. Using the set and get instructions.

thesecretmaster commented 5 years ago

Can't reproduce now, but we should definitely look into this. It looks like I squashed it by strduping in types/string.c#get, which really shouldn't be necessary (Actually it might be? But definitely not in my test case).

thesecretmaster commented 5 years ago

Update: Basically someone just needs to valgrind bin/predis without the strdup() in set() (types/string.c) and see what errors appear. Or run valgrind bin/predis-server and then bin/parallel-test and see what errors you get. Then fix them (or report back).

thesecretmaster commented 4 years ago

Note that it's impossible for a predis instance to be "full" anymore since we now have a resizable central hashtable.