theseer / phpdox

Documentation generator for PHP Code using standard technology (SRC, DOCBLOCK, XML and XSLT)
http://phpdox.de
Other
599 stars 121 forks source link

Git enricher does not work properly with Git 1.7.1 #325

Closed sebastianbergmann closed 6 years ago

sebastianbergmann commented 6 years ago

When I run

$ git clone https://github.com/sebastianbergmann/phpunit.git

$ cd phpunit

$ ant generate-project-documentation

on a system that has Git 1.7.1 then the Git enricher leaves the %B placeholder in the generated output.

If I run the same on a system that has Git 2.14.3 then the Git enricher produces useful output.

theseer commented 6 years ago

According to this commit to git, it seems %B is available since 1.7.2-rc0 which would make it a close miss for your version.

As that commit and version is about 7 years old, I'm not sure if I should still add support for it?

theseer commented 6 years ago

I guess I'll declare git < 1.7.2 as unsupported. I might add a check for that into the git enricher.

sebastianbergmann commented 6 years ago

Makes sense.