style.css: use protocol-relative google font paths

theseer / phpdox

Documentation generator for PHP Code using standard technology (SRC, DOCBLOCK, XML and XSLT)

http://phpdox.de

Other

600 stars 121 forks source link

style.css: use protocol-relative google font paths #348

Closed hemberger closed 5 years ago

hemberger commented 5 years ago

To avoid mixed content warnings when serving phpdox via HTTPS, use protocol-relative paths to the google font resources instead of hardcoding HTTP.

hemberger commented 5 years ago

Alternatively, we could just hardcode HTTPS (which seems to be the recommended pattern these days).

theseer commented 5 years ago

I actually never liked having an external resource for fonts.

We should check if the license allows for the font files to be bundled?

theseer commented 5 years ago

The font files as of commit 3c1bdc32b6ea29a50738aa6957144be77f136309 are now bundled. Thanks for pointing this out to being a problem. The change of this PR is luckily no longer required.