search

theseer / phpdox

Documentation generator for PHP Code using standard technology (SRC, DOCBLOCK, XML and XSLT)
http://phpdox.de
Other
600 stars 121 forks source link

Fix typehint for callable #358

Closed MacFJA closed 5 years ago

MacFJA commented 5 years ago

Expected result on tests/data/issue313 and on tests/data/issue233

Fix #313, Fix #233

theseer commented 5 years ago

I'm not really happy with now having a trait in phpDox.

But the general docblock implementation hasn't aged very well ;) Maybe I find some time to refactor this.

For now, i'll merge this as the implementation otherwise looks okay and I want this feature to be implemented.

theseer commented 5 years ago

Scrutinizer found an Issue after merging.

@MacFJA Can you have a look at that?

MacFJA commented 5 years ago

I'm not really happy with now having a trait in phpDox.

I see that phpDox don't have any trait. For the refactoring, instead of a composition by trait, a more traditional composition can be done (the interface only have on method that return a class which have the methods getBuiltInTypes and isBuiltInType)

Scrutinizer found an Issue after merging. @MacFJA Can you have a look at that?

I will check it this weekend, but I suspect some "conflict" with the PR #359