search

theseer / phpdox

Documentation generator for PHP Code using standard technology (SRC, DOCBLOCK, XML and XSLT)
http://phpdox.de
Other
600 stars 121 forks source link

Fix PHP7.2 object typehint (#354) #372

Closed MacFJA closed 4 years ago

MacFJA commented 4 years ago

I should have covered all cases.

How I handle it: when the type object is tested, I also check if the type have been resolved (<=> a full class path exist)

But I think the type transformation should be reworked, lots of similar XSL instruction exists. They look alike but are slightly different, which cause the maintainability cost to be quite high.

All those cases should be refactored into one XSLT function (or at least be in the same file, to avoid searching in multiple places).

theseer commented 4 years ago

I agree.

There's quite a few things that need cleaning up I'm afraid. I hope I'll find the time soon to do that.

Thanks for the PR!