Git version comparison bug in macOS

inash commented 4 years ago

https://github.com/theseer/phpdox/blob/3945e2d5f4298725688965baa0d79741f882eff2/src/generator/enricher/git/Git.php#L349

Git on macOS has an additional word in the version line which happens to be wrongly picked up to compare in method ensureGitVersionSupported. Instead of picking up 2.20.1, Git-117) is being picked up. Below is comparison of the git version string from different operating systems.

Linux: git version 2.20.1
Windows: git version 2.22.0.windows.1
macOS: git version 2.20.1 (Apple Git-117)

Instead of array_pop($parts), taking $parts[2] should be correct.

Qusonann commented 4 years ago

https://github.com/theseer/phpdox/pull/385 my MR should fix this (at least on macOS, haven't checked windows).

theseer commented 4 years ago

I'm not fully sure the implementation in PR #385 is the best yet, but it certainly will fix things.

Good enough for now and thus merged.

theseer / phpdox

Git version comparison bug in macOS #381