search

theseion / Fuel

Fuel, the Smalltalk object serializer
https://theseion.github.io/Fuel
MIT License
26 stars 12 forks source link

FLVersion Caching #263

Closed seandenigris closed 1 year ago

seandenigris commented 2 years ago

I wonder if the current version should be lazily initialized as in https://github.com/theseion/Fuel/blob/e44dd4b327dcaf69d1e74063e13df0fbeabc5364/repository/Fuel-Core.package/FLVersion.class/class/current.st

The version seems to be a rather cheap to create value object and the version may change (i.e. loading a newer Fuel version). I upgraded Fuel and was confused when serialization still stored the prior version and thus was un-materialize-able in my new image.

What about just

current
    ^ self
            newWithMajor: 5
            minor: 0
            patch: 1

maybe without even the class var...

tinchodias commented 2 years ago

+1 without the class var

theseion commented 2 years ago

Hm... yeah... 😅

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will remain open but will probably not come into focus. If you still think this should receive some attention, leave a comment. Thank you for your contributions.