theseion / Fuel

Fuel, the Smalltalk object serializer
https://theseion.github.io/Fuel
MIT License
27 stars 13 forks source link

Support for Pharo11 #264

Closed MarcusDenker closed 2 years ago

MarcusDenker commented 2 years ago

We use for now 4.1.1 (we want to move to 5 as soon as possible in Pharo11).

For both we need support for Pharo11 (the build is broken due to that: https://github.com/pharo-project/pharo/issues/11099 )

What needs to be done:

(SystemVersion current version beginsWith: 'Pharo11') ifTrue: [ ^ #('pharo11.x') ].
MarcusDenker commented 2 years ago

BaselineOfFuelPlatform seems to be a class in Pharo? this is all to complex...

MarcusDenker commented 2 years ago

PR to add it there: https://github.com/pharo-project/pharo/pull/11118

MarcusDenker commented 2 years ago

Nope, this is loaded from there:

[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1138)[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1139)[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1140)[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1141)[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1142)[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1143)[](https://ci.inria.fr/pharo-ci-jenkins2/blue/organizations/jenkins/Test%20pending%20pull%20request%20and%20branch%20Pipeline/detail/Pharo11/6/#step-26-log-1144)MetacelloNotification: Fetched -> BaselineOfFuelPlatform-cypress.1 --- github://theseion/FuelPlatform:stable/repository --- github://theseion/FuelPlatform:stable/repository
MetacelloNotification: Loading -> BaselineOfFuelPlatform-cypress.1 --- github://theseion/FuelPlatform:stable/repository --- github://theseion/FuelPlatform:stable/repository
MetacelloNotification: Loaded -> BaselineOfFuelPlatform-cypress.1 --- github://theseion/FuelPlatform:stable/repository --- github://theseion/FuelPlatform:stable/repository
Error: Could not determine image version. Using fallback
BaselineOfFuelPlatform>>platformAttributes
BaselineOfFuelPlatform>>customProjectAttributes
BaselineOfFuelPlatform(ConfigurationOf)>>project
MetacelloMCBaselineOfProjectSpec(MetacelloMCProjectSpec)>>projectClassProject

So it has to be fixed here.

But if I checkout the Fuel4.1.1, the repo does not contain BaselineOfFuelPlatform (or maybe I did something wrong?)

MarcusDenker commented 2 years ago

ah, it seems to another repository? https://github.com/theseion/FuelPlatform

MarcusDenker commented 2 years ago

I did https://github.com/theseion/FuelPlatform/pull/4

theseion commented 2 years ago

Sorry for the confusion :) I'll close this for now.