theseion / libgit2-pharo-bindings

libgit2 bindings for Pharo
http://theseion.github.io/libgit2-pharo-bindings
7 stars 29 forks source link

should be using BaselineOfLibGit #26

Closed dalehenrich closed 9 years ago

dalehenrich commented 9 years ago

@theseion if you were using a BaselineOf I think that things would be much cleaner ... there's not much advantage to using a ConfigurationOf for a GitHub-based project ...

I could give you a pull request with a BaselineOf, based on your current CofigurationOf if you'd like ...

theseion commented 9 years ago

Yes please!

dalehenrich commented 9 years ago

Okey dokey ... I'll see what I can do:)

theseion commented 9 years ago

Thanks Dale. I'll check it out later.

dalehenrich commented 9 years ago

No hurry ... if you have questions comment, try making inline comments on PR (https://github.com/theseion/LibGit/pull/27/files)

theseion commented 9 years ago

Very cool Dale, thanks! I've ditched the ConfigurationOf in favor of the BaselineOf.

tinchodias commented 9 years ago

Hi Dale and Max,

I have a project that depends on LibGit. In the ConfigurationOf, I changed to:

        spec 
            project: 'LibGit' with: [
                spec
                    baseline: #LibGit; 
                    repository: 'github://theseion/LibGit:master' ].

from:

        spec 
            project: 'LibGit' with: [
                spec
                    className: #ConfigurationOfLibGit;
                    versionString: #'bleedingEdge';
                    repository: 'http://smalltalkhub.com/mc/FileSystemGitDev/LibGit2/main/' ].

Is it right?

The loading has some problem.

theseion commented 9 years ago

Great! Does it work?

tinchodias commented 9 years ago

Ooops, you answered too fast, while I was editing my post :)

Strangely, it loads fine when doing directly "ConfigurationOfYrupe loadBleedingEdge", but it doesn't load when doing "ConfigurationOfFicus loadBleedingEdge", which depends on ConfigurationOfYrupe.

So, to make it more clear, the dependencies are:

Yrupe -> Ficus -> LibGit

theseion commented 9 years ago

Solved.