search

theseion / libgit2-pharo-bindings

libgit2 bindings for Pharo
http://theseion.github.io/libgit2-pharo-bindings
7 stars 29 forks source link

Added the git_tree_entry_byname and git_tree_entry_bypath functions to the LGitTree class. #40

Closed jvdsandt closed 8 years ago

theseion commented 8 years ago

Thanks. I'll look at your PR in the next few days.

theseion commented 8 years ago

Thanks for writing tests!

There's one thing I'd like you to change: #tree_entry_bypath:tree:path: should use #call:options, not the unchecked variant. That will prevent the call from crashing the VM if the tree doesn't have a handle yet.

I'll leave the PR open.

jvdsandt commented 8 years ago

Ok, I have removed the unchecked call