search

theseion / libgit2-pharo-bindings

libgit2 bindings for Pharo
http://theseion.github.io/libgit2-pharo-bindings
7 stars 29 forks source link

Error when reading blob binary contents #9

Closed tinchodias closed 9 years ago

tinchodias commented 9 years ago

My image was crashing when executing LGtBlob>>contents of a blob with binary content. (I checked that it answers true to LGtBlob>>isBinary)

My blob had this content:

'SUnit tests for fuel serializations, here signatures$$'

Where $ is the ascii character 5 (i.e. insert).

Weird. I tried modifying the current #testBinary with my particular string and there is no problem. But in my scenario was 100% reproducible.

theseion commented 9 years ago

Great, thanks. I'll look into that.

theseion commented 9 years ago

I can't reproduce the problem either. Can you still reproduce it in a more complex scenario? It's possible that you're seeing a side effect of some other problem (e.g. buffer overflow after a different operation).

tinchodias commented 9 years ago

Thanks. I can try to find a test case to reproduce. Or we can just close this issue and wait to see if it re-appears.

theseion commented 9 years ago

On 15 Dec 2014, at 10:35, Martín Dias notifications@github.com wrote:

Thanks. I can try to find a test case to reproduce. Or we can just close this issue and wait to see if it re-appears.

I’d rather fix this now than hope to find the cause later. So if you can find a way to reproduce it that would be great.

— Reply to this email directly or view it on GitHub https://github.com/theseion/LibGit/issues/9#issuecomment-66968863.

theseion commented 9 years ago

Not reproducible.