thesentinelproject / threatwiki_node

Threatwiki - genocide risk tracking and visualization platform to help monitor communities at risk of genocide around the world
Other
63 stars 25 forks source link

Add middleware to ensure integrity of model #6

Closed abhishekbh closed 11 years ago

abhishekbh commented 12 years ago

Make sure repeated data in the model always stays in sync.

jeromegv commented 12 years ago

Not sure how it wouldn't stay in sync? Trying to understand what the real issue is here.

abhishekbh commented 12 years ago

Yeah this is essentially a filler task, I haven't done the research behind it yet.

The reason for it is though that I fear that our model could break or fall out of sync since we're doing everything manually. Imagine for example that at some point in the future, any one document is fairly complex and requires controller code behind the mappers. Since we are repeating the CRUD operations separately for documents like SOC, we would have to update two files manually. There is a chance that they could fall out of sync, or do things differently.

So this issue would simply be thinking of ways to remove code duplication, perhaps through some sort of solid middleware. Like I said, the specifics have to be thought out, but it is something on my mind, so I put it down.

Definitely open to discussions and ideas on this one.

Abhishek On May 21, 2012 2:33 PM, "jeromegv" < reply@reply.github.com> wrote:

Not sure how it wouldn't stay in sync? Trying to understand what the real issue is here.


Reply to this email directly or view it on GitHub:

https://github.com/thesentinelproject/threatwiki_node/issues/6#issuecomment-5830070

abhishekbh commented 12 years ago

removing from current milestone; this will have to be rethunk

jeromegv commented 11 years ago

6 months later it doesn't seem like the need came up and created any problem, let's close it for now