thesentinelproject / threatwiki_node

Threatwiki - genocide risk tracking and visualization platform to help monitor communities at risk of genocide around the world
Other
63 stars 25 forks source link

Ensure all GET Tests work #7

Closed abhishekbh closed 12 years ago

jeromegv commented 12 years ago

Agreed we will use a better test framework, waiting for answer from Ahbishek's friend. Suggestions from Taneem: Jasmine or Zombie

abhishekbh commented 12 years ago

Found it: http://vowsjs.org/

Please consider it and let me know what you think.

I can being installing this tomorrow if this is fine.

jeromegv commented 12 years ago

There is nodeunit as well https://github.com/caolan/nodeunit

Found this: http://stackoverflow.com/questions/7254025/node-js-unit-testing

And this: http://stackoverflow.com/questions/5370222/unit-testing-framework-for-node-js-that-specifically-supports-testing-async-code

To be honest, I don't think my knowledge in unit testing is good enough to know what library would work best with our typical use cases..

On Sun, Jun 3, 2012 at 8:37 PM, Abhishek Bhatnagar < reply@reply.github.com

wrote:

Found it: http://vowsjs.org/

Please consider it and let me know what you think.

I can being installing this tomorrow if this is fine.


Reply to this email directly or view it on GitHub:

https://github.com/thesentinelproject/threatwiki_node/issues/7#issuecomment-6090516

Jérôme Gagnon-Voyer | Technology Analyst jerome@thesentinelproject.org | Skype: jeromegagnonvoyer

abhishekbh commented 12 years ago

Hmm, yeah there are like 30 popular frameworks at the moment.

I'd vote to vows for two reasons that I read online:

Apparently most of the other features these guys share are the same.

abhishekbh commented 12 years ago

Yeah, so I heard back Zombie for frontend, Vows for backend.

I'm with okay with this path. Any objections?

jeromegv commented 12 years ago

All good

Le 2012-06-04 à 20:02, Abhishek Bhatnagar reply@reply.github.com a écrit :

Yeah, so I heard back Zombie for frontend, Vows for backend.

I'm with okay with this path. Any objections?


Reply to this email directly or view it on GitHub: https://github.com/thesentinelproject/threatwiki_node/issues/7#issuecomment-6114712

abhishekbh commented 12 years ago

Okay, added vows.

For this iteration, we should probably only write tests in vows right? With this thinking I added only vows for now.

Did you want to split up the work in vows? We essentially have to write a test for every function the API provides. Did you want to take two files and I take the other two?

jeromegv commented 12 years ago

Sure

Le 2012-06-06 à 00:47, Abhishek Bhatnagar reply@reply.github.com a écrit :

Okay, added vows.

For this iteration, we should probably only write tests in vows right? With this thinking I added only vows for now.

Did you want to split up the work in vows? We essentially have to write a test for every function the API provides. Did you want to take two files and I take the other two?


Reply to this email directly or view it on GitHub: https://github.com/thesentinelproject/threatwiki_node/issues/7#issuecomment-6142953

jeromegv commented 12 years ago

Did you get started on something? Where should we put those test files? Not sure where to start, especially if you started on your side

jeromegv commented 12 years ago

starting some basic implementation, with Tobi to do the API calls, used this to help out to start: https://gist.github.com/1117455