theseus-rs / rsql

Command line interface for CockroachDB, DuckDB, LibSQL, MariaDB, MySQL, PostgreSQL, Redshift, Snowflake, SQLite3 and SQL Server
https://theseus-rs.github.io/rsql/rsql_cli/
Apache License 2.0
129 stars 5 forks source link

refactor!: rename Connection.stop() to Connection.close() #102

Closed brianheineman closed 7 months ago

github-actions[bot] commented 7 months ago

🐰Bencher

ReportWed, April 3, 2024 at 17:47:56 UTC
Projecttheseus-rs/rsql
Branchrefactor-close
Testbedlocalhost
BenchmarkLatencyLatency Results
nanoseconds (ns)
postgres-embedded➖ (view plot)807050000.000
postgresql-embedded➖ (view plot)821130000.000
rusqlite➖ (view plot)267140.000
sqlite➖ (view plot)505110.000

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.03%. Comparing base (d7d7dd3) to head (2998e5b).

Files Patch % Lines
rsql_core/src/shell/repl.rs 66.66% 1 Missing :warning:
rsql_drivers/src/mysql/driver.rs 0.00% 1 Missing :warning:
rsql_drivers/src/postgres/driver.rs 90.00% 1 Missing :warning:
rsql_drivers/src/postgresql/driver.rs 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== - Coverage 96.05% 96.03% -0.03% ========================================== Files 76 76 Lines 8189 8195 +6 ========================================== + Hits 7866 7870 +4 - Misses 323 325 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.