theseus-rs / rsql

Command line interface for CockroachDB, DuckDB, LibSQL, MariaDB, MySQL, PostgreSQL, Redshift, Snowflake, SQLite3 and SQL Server
https://theseus-rs.github.io/rsql/rsql_cli/
Apache License 2.0
129 stars 5 forks source link

refactor!: add Value::Null and remove Option<Value> from Row interfaces #133

Closed brianheineman closed 6 months ago

github-actions[bot] commented 6 months ago

🐰Bencher

ReportFri, May 10, 2024 at 19:01:08 UTC
Projecttheseus-rs/rsql
Branchadd-value-null
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
duckdb➖ (view plot)3,964,700.00
postgres-embedded➖ (view plot)813,740,000.00
postgresql-embedded➖ (view plot)828,330,000.00
rusqlite➖ (view plot)293,130.00
sqlite➖ (view plot)526,520.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 81.28492% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 95.56%. Comparing base (825667a) to head (90a7630).

Files Patch % Lines
rsql_drivers/src/mysql/driver.rs 71.87% 18 Missing :warning:
rsql_drivers/src/postgresql/driver.rs 68.42% 18 Missing :warning:
rsql_drivers/src/sqlserver/driver.rs 67.50% 13 Missing :warning:
rsql_drivers/src/sqlite/driver.rs 72.97% 10 Missing :warning:
rsql_drivers/src/postgres/driver.rs 72.22% 5 Missing :warning:
rsql_drivers/src/duckdb/driver.rs 90.47% 2 Missing :warning:
rsql_drivers/src/rusqlite/driver.rs 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ========================================== - Coverage 96.09% 95.56% -0.54% ========================================== Files 89 89 Lines 9856 9889 +33 ========================================== - Hits 9471 9450 -21 - Misses 385 439 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.