theseus-rs / rsql

Command line interface for CockroachDB, DuckDB, LibSQL, MariaDB, MySQL, PostgreSQL, Redshift, Snowflake, SQLite3 and SQL Server
https://theseus-rs.github.io/rsql/rsql_cli/
Apache License 2.0
129 stars 5 forks source link

feat: basic autocomplete of table names where metadata is available. … #193

Closed gazure closed 1 month ago

gazure commented 2 months ago

Describe the pull request

First pass at implementing a sql completer specified by #188

added a setting to enable/disable new completions.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.60853% with 35 lines in your changes missing coverage. Please review.

Project coverage is 93.81%. Comparing base (78477a7) to head (6d8683b). Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
rsql_core/src/shell/completer.rs 95.37% 23 Missing :warning:
rsql_drivers/src/metadata.rs 80.95% 8 Missing :warning:
rsql_drivers/src/connection.rs 95.23% 2 Missing :warning:
rsql_core/src/shell/repl.rs 93.75% 1 Missing :warning:
rsql_drivers/src/snowflake/driver.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #193 +/- ## ========================================== + Coverage 93.30% 93.81% +0.51% ========================================== Files 93 94 +1 Lines 11912 12678 +766 ========================================== + Hits 11114 11894 +780 + Misses 798 784 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brianheineman commented 1 month ago

Thanks for the PR! 🎉

gazure commented 1 month ago

🎉