theseus-rs / rsql

Command line interface for CockroachDB, DuckDB, LibSQL, MariaDB, MySQL, PostgreSQL, Redshift, Snowflake, SQLite3 and SQL Server
https://theseus-rs.github.io/rsql/rsql_cli/
Apache License 2.0
129 stars 5 forks source link

fix: revert sqlx from 0.8.2 to 0.7.4 to correct mysql and mariadb string conversion errors #198

Closed brianheineman closed 1 month ago

brianheineman commented 1 month ago

Reverting sqlx to version 0.7.4 to address string handling bugs:

https://github.com/launchbadge/sqlx/issues/3387 https://github.com/launchbadge/sqlx/issues/3390

github-actions[bot] commented 1 month ago

🐰 Bencher Report

Branchrevert-sqlx
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
postgres-embedded📈 view plot
⚠️ NO THRESHOLD
809,080,000.00
postgresql-embedded📈 view plot
⚠️ NO THRESHOLD
826,640,000.00
rusqlite📈 view plot
⚠️ NO THRESHOLD
4,556,100.00
sqlite📈 view plot
⚠️ NO THRESHOLD
4,878,000.00
🐰 View full continuous benchmarking report in Bencher
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.92%. Comparing base (fe2ea1c) to head (b35a31d). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== + Coverage 90.24% 93.92% +3.67% ========================================== Files 93 93 Lines 11692 11716 +24 ========================================== + Hits 10552 11004 +452 + Misses 1140 712 -428 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.