search

theseus-rs / rsql

Command line interface for CockroachDB, DuckDB, LibSQL, MariaDB, MySQL, PostgreSQL, Redshift, Snowflake, SQLite3 and SQL Server
https://theseus-rs.github.io/rsql/rsql_cli/
Apache License 2.0
129 stars 5 forks source link

Pre-execution query analysis. #200

Closed gazure closed 1 month ago

gazure commented 1 month ago

Describe the pull request

Adds functions to Connection to enable the repl to perform more robust pre-execution query analysis. Currently used to identify SELECT statements.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 60.28708% with 83 lines in your changes missing coverage. Please review.

Project coverage is 93.36%. Comparing base (42ef9d2) to head (77ec50a). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
rsql_drivers/src/connection.rs 82.89% 13 Missing :warning:
rsql_drivers/src/redshift/driver.rs 36.84% 12 Missing :warning:
rsql_drivers/src/postgres/driver.rs 0.00% 11 Missing :warning:
rsql_drivers/src/postgresql/driver.rs 0.00% 11 Missing :warning:
rsql_drivers/src/rusqlite/driver.rs 0.00% 11 Missing :warning:
rsql_drivers/src/sqlite/driver.rs 0.00% 11 Missing :warning:
rsql_core/src/executors/error.rs 0.00% 3 Missing :warning:
rsql_drivers/src/mysql/driver.rs 0.00% 3 Missing :warning:
rsql_drivers/src/snowflake/driver.rs 0.00% 3 Missing :warning:
rsql_drivers/src/sqlserver/driver.rs 0.00% 3 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## ========================================== - Coverage 93.95% 93.36% -0.59% ========================================== Files 94 94 Lines 11756 11965 +209 ========================================== + Hits 11045 11171 +126 - Misses 711 794 +83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brianheineman commented 1 month ago

Does it make sense to add the Redshift dialect to this PR as well?