search

theshoregroup / digital-signage

A powerful, extensible digital signage solution by The Shore Group, written in ReactJS, wrapped in Electron for some system-level integration not possible with a PWA, and styled with TailwindCSS.
digital-signage-smoky.vercel.app
MIT License
11 stars 3 forks source link

Dev branch #25

Closed finnjefferis closed 2 years ago

limegorilla commented 2 years ago

Might want to check the variable apidata - as this is a CI environment any warnings (i.e things the terminal will flag at you, but not things that would kill the app) are treated as errors and either need to be ignored/fixed.

Screenshot 2022-01-07 at 4 25 03 pm

Check to see if you need it - if you're not sure I'd probably try commenting it out (in JS that's by putting // in front of the line) and either remove or comment it out

limegorilla commented 2 years ago

Added dummy JSON arrays so app starts correctly · theshoregroupdigital-signage@3cbb684

Hi @finnjefferis, looking like ‘bottom’ is now unused. Make sure your actually using any variables otherwise it will throw a warning when building, which will throw it.

finnjefferis commented 2 years ago

Hi Liam,

Merge should be sorted now.