thesimplekid / cashu-rs-mint

Cashu mint useing CDK
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

fix: darwin builds and shell aliases #5

Open storopoli opened 5 months ago

storopoli commented 5 months ago

Cc @plebhash who was also experiencing issues.

plebhash commented 5 months ago

I tested and the errors coming from bitcoind cleared up on darwin.

But for some reason, the resulting lightningd binary does not have a --bitcoin-datadir CLI option on a darwin build:

lightningd: --bitcoin-datadir=/tmp/cashu-rs-mint/bitcoin: unknown option

This does not happen on linux.

edit: this seems to be an issue with the clightning derivation on darwin. reported here https://github.com/NixOS/nixpkgs/issues/305060

thesimplekid commented 5 months ago

Thanks for this. I am not currently testing on darwin but I should. I'm happy to merge the changes as they're working for me on nixos but haven't run them on darwin. Looking at @plebhash's comment it looks like it fixes one issue but creates another so still doesn't work on darwin?

storopoli commented 5 months ago

Yes it is an issue reported upstream to NixOS/nixpkgs. We should wait for updates there.

storopoli commented 4 months ago

This is ready to merge now, ping @thesimplekid.

plebhash commented 4 months ago

This is ready to merge now, ping @thesimplekid.

was there any progress on the clightning derivation for darwin? I don't see any updates from the issues I created.

storopoli commented 4 months ago

Ok I saw wrong issues, thanks for linking the right ones :)