thesis / acre

Bitcoin Liquid Staking
https://acre.fi
GNU General Public License v3.0
7 stars 2 forks source link

dApp: Fix ` $.getBitcoinProvider is not a function` error #771

Open kpyszkowski opened 1 week ago

kpyszkowski commented 1 week ago

Sentry error here

My assumption is it occurs when user has deprecated version of the wallet extension. With explicit check if the function exists the issue is resolved.

netlify[bot] commented 1 week ago

Deploy Preview for acre-dapp ready!

Name Link
Latest commit 9550595fd16c2a18b2f3863aa0b0ec9d848d678e
Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/6711265d71c5f50008977008
Deploy Preview https://deploy-preview-771--acre-dapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for acre-dapp-testnet ready!

Name Link
Latest commit 9550595fd16c2a18b2f3863aa0b0ec9d848d678e
Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/6711265da303a80008b8dc32
Deploy Preview https://deploy-preview-771--acre-dapp-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kkosiorowska commented 6 days ago

My assumption is it occurs when user has deprecated version of the wallet extension. With explicit check if the function exists the issue is resolved.

I think that the version of the extension does not affect this error here. Hook useConnector returns a connector from OrangeKit which should have an implemented method getBitcoinProvider. See here. Therefore, we do not need to check if the function exists in the connector object.